flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier
Date Tue, 12 Jul 2016 16:53:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373229#comment-15373229
] 

ASF GitHub Bot commented on FLINK-4143:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2219#discussion_r70475544
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
    @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {
     		}
     		this.scopeFormats = scopeFormats;
     
    +		char delim;
    +		try {
    +			delim = config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".").charAt(0);
    --- End diff --
    
    why do you post the same comment twice?
    
    There isn't a particular reason for using a char. ScopeFormat.concat has a var arg String
argument, and as such couldn't differentiate between cases with or without a delimiter. So
i opted for the simple approach of using a char instead of investing more time into a feature
for something that IMO won't be used anyway.


> Configurable delimiter for metric identifier
> --------------------------------------------
>
>                 Key: FLINK-4143
>                 URL: https://issues.apache.org/jira/browse/FLINK-4143
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> The metric identifier is currently hard-coded to separate components with a dot.
> We should make this configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message