flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4171) StatsD does not accept metrics whose name contains ":"
Date Thu, 07 Jul 2016 13:32:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366093#comment-15366093
] 

ASF GitHub Bot commented on FLINK-4171:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2212

    [FLINK-4171] [metrics] Replace : chars in StatsD metric names

    The StatsD server rejects metrics whose names contain the : character. Therefore,
    metric names which contain : chars will be altered so that : is replaced by -.
    
    R @zentol 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixStatsDReporting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2212
    
----
commit b9237aa57576cdc9916739148fdb9832ccbf71e6
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-07-07T13:26:51Z

    [FLINK-4171] [metrics] Replace : chars in StatsD metric names
    
    The StatsD server rejects metrics whose names contain the : character. Therefore,
    metric names which contain : chars will be altered so that : is replaced by -.

----


> StatsD does not accept metrics whose name contains ":"
> ------------------------------------------------------
>
>                 Key: FLINK-4171
>                 URL: https://issues.apache.org/jira/browse/FLINK-4171
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.1.0
>
>
> The {{StatsDReporter}} mustn't send metrics whose name contains a ":" character to {{StatsD}}
because these reports are discarded. The reason is that ":" is used to separate the value
from the metric name.
> I propose to check the metric names and replace all ":" by a "-" character.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message