flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration
Date Thu, 21 Jul 2016 13:39:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387697#comment-15387697
] 

ASF GitHub Bot commented on FLINK-4202:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2271#discussion_r71705985
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
---
    @@ -0,0 +1,321 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.executiongraph;
    +
    +import org.apache.flink.api.common.ExecutionConfig;
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.metrics.Gauge;
    +import org.apache.flink.metrics.Metric;
    +import org.apache.flink.metrics.MetricGroup;
    +import org.apache.flink.metrics.MetricRegistry;
    +import org.apache.flink.metrics.groups.AbstractMetricGroup;
    +import org.apache.flink.metrics.groups.JobManagerMetricGroup;
    +import org.apache.flink.metrics.reporter.MetricReporter;
    +import org.apache.flink.runtime.JobException;
    +import org.apache.flink.runtime.blob.BlobKey;
    +import org.apache.flink.runtime.execution.ExecutionState;
    +import org.apache.flink.runtime.executiongraph.restart.RestartStrategy;
    +import org.apache.flink.runtime.instance.ActorGateway;
    +import org.apache.flink.runtime.instance.Instance;
    +import org.apache.flink.runtime.instance.InstanceConnectionInfo;
    +import org.apache.flink.runtime.instance.SimpleSlot;
    +import org.apache.flink.runtime.instance.Slot;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.jobgraph.JobStatus;
    +import org.apache.flink.runtime.jobgraph.JobVertex;
    +import org.apache.flink.runtime.jobmanager.Tasks;
    +import org.apache.flink.runtime.jobmanager.scheduler.ScheduledUnit;
    +import org.apache.flink.runtime.jobmanager.scheduler.Scheduler;
    +import org.apache.flink.runtime.messages.Messages;
    +import org.apache.flink.runtime.taskmanager.TaskExecutionState;
    +import org.apache.flink.util.SerializedValue;
    +import org.apache.flink.util.TestLogger;
    +import org.junit.Test;
    +import org.mockito.Matchers;
    +import scala.concurrent.ExecutionContext$;
    +import scala.concurrent.Future$;
    +import scala.concurrent.duration.FiniteDuration;
    +
    +import java.io.IOException;
    +import java.net.URL;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.ForkJoinPool;
    +import java.util.concurrent.TimeUnit;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNotNull;
    +import static org.junit.Assert.assertTrue;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.when;
    +
    +public class ExecutionGraphMetricsTest extends TestLogger {
    +
    +	/**
    +	 * This test tests that the restarting time metric correctly displays restarting times.
    +	 */
    +	@Test
    +	public void testExecutionGraphRestartTimeMetric() throws JobException, IOException,
InterruptedException {
    --- End diff --
    
    Very good test 👍 


> Add JM metric which shows the restart duration
> ----------------------------------------------
>
>                 Key: FLINK-4202
>                 URL: https://issues.apache.org/jira/browse/FLINK-4202
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.1.0
>
>
> It is convenient for users to have a metric which tells you how long the restarting of
a job has taken.
> I propose a to introduce a {{Gauge}} which returns the time between {{JobStatus.RESTARTING}}
and {{JobStatus.RUNNING}}. If the job was not restarted (initial run), then this metric will
return {{-1}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message