flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging
Date Mon, 25 Jul 2016 14:34:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392001#comment-15392001

ASF GitHub Bot commented on FLINK-4239:

Github user kl0u commented on a diff in the pull request:

    --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java
    @@ -114,8 +115,8 @@ private void runTest(
     			windowedStream = windowedStream.allowedLateness(Time.milliseconds(ALLOWED_LATENESS_MS));
    -		if (!PURGE_WINDOW_ON_FIRE) {
    -			windowedStream = windowedStream.trigger(new NonPurgingEventTimeTriggerWrapper());
    +		if (PURGE_WINDOW_ON_FIRE) {
    +			windowedStream = windowedStream.trigger(PurgingTrigger.of(EventTimeTrigger.create()));
    --- End diff --
    I do not know if this behavior existed before, but now if you set the PURGE_WINDOW_ON_FIRE
to true, now the test fails.

> Set Default Allowed Lateness to Zero and Make Triggers Non-Purging
> ------------------------------------------------------------------
>                 Key: FLINK-4239
>                 URL: https://issues.apache.org/jira/browse/FLINK-4239
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming
>    Affects Versions: 1.1.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
> In preparation for upcoming changes in 1.2 we should set the default allowed lateness
to zero and make all built-in triggers non-purging by default. 
> Currently, {{EventTimeTrigger}} and {{ProcessingTimeTrigger}} purge when they fire. This
leads to unexpected behavior when a user sets some meaningful allowed lateness. The behavior
will be that the window is purged when firing and the state will not actually be kept within
the allowed lateness.
> Changing the behavior to non-purging requires changing the default allowed lateness from
{{Long.MAX_VALUE}} to {{0}}. Otherwise we would have memory leaks.

This message was sent by Atlassian JIRA

View raw message