flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4242) Improve validation exception messages
Date Sat, 23 Jul 2016 16:08:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390751#comment-15390751
] 

ASF GitHub Bot commented on FLINK-4242:
---------------------------------------

GitHub user gallenvara opened a pull request:

    https://github.com/apache/flink/pull/2290

    [FLINK-4242] [table] Improve validation exception messages

    Improve validation exception messages in table api.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gallenvara/flink flink-4242

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2290
    
----
commit d79e03d3bc8e5d4387e78b1a648a26ca465fb442
Author: gallenvara <gallenvara@126.com>
Date:   2016-07-23T15:59:01Z

    Improve validation exception messages in table api.

----


> Improve validation exception messages
> -------------------------------------
>
>                 Key: FLINK-4242
>                 URL: https://issues.apache.org/jira/browse/FLINK-4242
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>
> The Table API's validation exceptions could be improved to be more meaningful for users.
For example, the following code snippet:
> {code}
> Table inputTable = tableEnv.fromDataStream(env.fromElements(
>                 Tuple3.of(1, "a", 1.0),
>                 Tuple3.of(2, "b", 2.0),
>                 Tuple3.of(3, "c", 3.0)), "a, b, c");
> inputTable.select("a").where("!a");
> {code}
> fails correctly. However, the validation exception message says "Expression !('a) failed
on input check: Not only accepts child of Boolean Type, get Integer". I think it could be
changed such that it says: "The not operator requires a boolean input but "a" is of type integer."
or something similar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message