flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters
Date Fri, 22 Jul 2016 14:04:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389551#comment-15389551
] 

ASF GitHub Bot commented on FLINK-4246:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2285#discussion_r71883403
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
    @@ -51,9 +51,11 @@ public void testJobManagerMetricAccess() throws Exception {
     		Deadline deadline = new FiniteDuration(2, TimeUnit.MINUTES).fromNow();
     		Configuration flinkConfiguration = new Configuration();
     
    -		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_CLASS, "org.apache.flink.metrics.reporter.JMXReporter");
    +		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTERS_LIST, "test");
    +		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test.class",
"org.apache.flink.metrics.reporter.JMXReporter");
    --- End diff --
    
    shouldn't we uses the ConfigConstants.METRICS_REPORTER_CLASS here instead of `.class`
? I know it blows up the line, but it still is a defined constant. (the same applies to ExecutionGraphMetricsTest)


> Allow Specifying Multiple Metrics Reporters
> -------------------------------------------
>
>                 Key: FLINK-4246
>                 URL: https://issues.apache.org/jira/browse/FLINK-4246
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>             Fix For: 1.1.0
>
>
> We should allow specifying multiple reporters. A rough sketch of how the configuration
should look like is this:
> {code}
> metrics.reporters = foo,bar
> metrics.reporter.foo.class = JMXReporter.class
> metrics.reporter.foo.port = 42-117
> metrics.reporter.bar.class = GangliaReporter.class
> metrics.reporter.bar.port = 512
> metrics.reporter.bar.whatever = 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message