flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters
Date Fri, 22 Jul 2016 15:37:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389703#comment-15389703
] 

ASF GitHub Bot commented on FLINK-4246:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2285#discussion_r71898897
  
    --- Diff: flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
    @@ -137,9 +140,11 @@ public void testStatsDHistogramReporting() throws Exception {
     			int port = receiver.getPort();
     
     			Configuration config = new Configuration();
    -			config.setString(ConfigConstants.METRICS_REPORTER_CLASS, StatsDReporter.class.getName());
    -			config.setString(ConfigConstants.METRICS_REPORTER_INTERVAL, "1 SECONDS");
    -			config.setString(ConfigConstants.METRICS_REPORTER_ARGUMENTS, "--host localhost --port
" + port);
    +			config.setString(ConfigConstants.METRICS_REPORTERS_LIST, "test");
    +			config.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test.class", StatsDReporter.class.getName());
    --- End diff --
    
    using `.class` instead of `METRICS_REPORTER_CLASS_SUFFIX`


> Allow Specifying Multiple Metrics Reporters
> -------------------------------------------
>
>                 Key: FLINK-4246
>                 URL: https://issues.apache.org/jira/browse/FLINK-4246
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>             Fix For: 1.1.0
>
>
> We should allow specifying multiple reporters. A rough sketch of how the configuration
should look like is this:
> {code}
> metrics.reporters = foo,bar
> metrics.reporter.foo.class = JMXReporter.class
> metrics.reporter.foo.port = 42-117
> metrics.reporter.bar.class = GangliaReporter.class
> metrics.reporter.bar.port = 512
> metrics.reporter.bar.whatever = 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message