From issues-return-63236-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Fri Jul 22 14:04:23 2016 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA2F0199BF for ; Fri, 22 Jul 2016 14:04:23 +0000 (UTC) Received: (qmail 48723 invoked by uid 500); 22 Jul 2016 14:04:23 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 48684 invoked by uid 500); 22 Jul 2016 14:04:23 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 48675 invoked by uid 99); 22 Jul 2016 14:04:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jul 2016 14:04:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1CC9ECA17F for ; Fri, 22 Jul 2016 14:04:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.307 X-Spam-Level: X-Spam-Status: No, score=-5.307 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.287] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2e26wFRRSyEZ for ; Fri, 22 Jul 2016 14:04:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 2CD995FBDF for ; Fri, 22 Jul 2016 14:04:19 +0000 (UTC) Received: (qmail 47771 invoked by uid 99); 22 Jul 2016 14:04:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jul 2016 14:04:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E533DE058E; Fri, 22 Jul 2016 14:04:18 +0000 (UTC) From: zentol To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep... Content-Type: text/plain Message-Id: <20160722140418.E533DE058E@git1-us-west.apache.org> Date: Fri, 22 Jul 2016 14:04:18 +0000 (UTC) Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71883403 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java --- @@ -51,9 +51,11 @@ public void testJobManagerMetricAccess() throws Exception { Deadline deadline = new FiniteDuration(2, TimeUnit.MINUTES).fromNow(); Configuration flinkConfiguration = new Configuration(); - flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_CLASS, "org.apache.flink.metrics.reporter.JMXReporter"); + flinkConfiguration.setString(ConfigConstants.METRICS_REPORTERS_LIST, "test"); + flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test.class", "org.apache.flink.metrics.reporter.JMXReporter"); --- End diff -- shouldn't we uses the ConfigConstants.METRICS_REPORTER_CLASS here instead of `.class` ? I know it blows up the line, but it still is a defined constant. (the same applies to ExecutionGraphMetricsTest) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---