flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vijikarthi <...@git.apache.org>
Subject [GitHub] flink pull request #2275: FLINK-3929 Support for Kerberos Authentication wit...
Date Mon, 01 Aug 2016 18:06:03 GMT
Github user vijikarthi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2275#discussion_r73023816
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
---
    @@ -81,13 +90,21 @@ public static void prepare() throws IOException, ClassNotFoundException
{
     		LOG.info("-------------------------------------------------------------------------");
     		LOG.info("    Starting KafkaTestBase ");
     		LOG.info("-------------------------------------------------------------------------");
    -		
     
    +		Configuration flinkConfig = new Configuration();
     
     		// dynamically load the implementation for the test
     		Class<?> clazz = Class.forName("org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl");
     		kafkaServer = (KafkaTestEnvironment) InstantiationUtil.instantiate(clazz);
     
    +		LOG.info("Runtype: {}", RunTypeHolder.get());
    +		if(RunTypeHolder.get().equals(RunTypeHolder.RunType.SECURE)
    --- End diff --
    
    Yes == is more appropriate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message