flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() expects ...
Date Thu, 04 Aug 2016 21:31:12 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2298
  
    +1 for sticking to Java DataSet / DataStream for the reasons @twalthr gave. The methods
should be tagged with the `@Internal` annotation when we add them to the Table API.
    
    I would not rename `TableSource` to `TableInputFormat` because 1) it has no relationship
to the `InputFormat` interface and 2) there is already a `TableInputFormat` for HBase tables
(name is not very fortunate though...).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message