flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...
Date Thu, 11 Aug 2016 08:46:35 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2244#discussion_r74386541
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Row.scala
---
    @@ -31,6 +31,10 @@ class Row(arity: Int) extends Product {
     
       def setField(i: Int, value: Any): Unit = fields(i) = value
     
    +  def getField(i: Int): Any = fields(i)
    --- End diff --
    
    Why did you add those methods? `productArity` and `productElement` already do what you
want.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message