flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink issue #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1)
Date Thu, 18 Aug 2016 13:25:50 GMT
Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2315
  
    Thank you for your work @EronWright.  Finally could go through the code. All in all, very
impressive as the first step of the Mesos integration! I think this PR is in a mergeable state
if some minor comments are addressed.
    
    I'm not 100 % sure about all the additional actors yet. It seems like `ReconciliationCoordinator`,
`ConnectionMonitor`, `TaskMonitor` could also easily be handled inside `MesosFlinkResourceManager`.
In terms of modularity, I can see that having these run independently can give us a more flexible
setup. Which of the actors do you plan to re-use in the next set of changes? Clearly, in terms
of testability it comes in really handy. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message