flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink issue #2389: [FLINK-4348] [cluster management] Implement communication...
Date Mon, 22 Aug 2016 14:33:42 GMT
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2389
  
    Thanks for your contribution @beyond1920 :-) I've reviewed the PR and I think it would
be good if we split it up into several parts. The first part could be the heartbeat logic
a.k.a. `HeartbeatManager`.   Here we could try to implement a generic sending and receiving
end. I think the implementation can almost be independent of the JM, RM and TE implementation
(similar to `RetryingRegistration`). This will allow us to easily test this component.
    
    The next step would be the integration of this component into the RM, JM and TE.
    
    Concerning the slot request logic I think we should wait a little bit for the `SlotManager`
implementation. It could be the case that the `SlotManager` will make the rpcs to the `TaskExecutor`
and not the RM. But for the moment the interface is, afaik, not well enough specified to program
against it.
    
    The failure notification should also be treated in a separate PR imo. The notification
can have multiple origins (e.g. `HeartbeatManager` or the resource management framework) and
should be designed in such a way.
    
    In general, I think the components should be more thoroughly tested with more fine-grained
unit tests. Furthermore, I think it would be good if we could revise the code documentation
a little bit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message