flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #2411: [FLINK-4453] [docs] Scala code example in Window document...
Date Wed, 24 Aug 2016 07:36:14 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2411
  
    Thanks for the quick fix, @wuchong!
    The change looks good, but I just realized that the Java code might be on purpose in the
Scala tab. It shows the interface of the `WindowFunction` which is defined in Java and the
same interface is used by the Scala API. So not sure if we should translate the code to Scala
because a Scala version of the interface does not exist.
    
    Maybe adding a comment that the Scala API uses Java interfaces is better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message