flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #2428: [FLINK-4517] scala code refactoring
Date Mon, 29 Aug 2016 09:15:42 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2428
  
    I am a bit cautious with such changes. There is no necessity to change the code, it only
looses history, and there is always a slight risk of a new bug appearing.
    
    Some of the styles you are adjusting were actually good as they were before. For example,
I personally very much prefer to always call Java Methods always with Parenthesis, since they
are always defined with parenthesis.
    
    How about we just update code style on the fly in the parts we touch anyways?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message