flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos
Date Thu, 18 Aug 2016 10:17:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426220#comment-15426220
] 

ASF GitHub Bot commented on FLINK-1984:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2315#discussion_r75282731
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/StandaloneMesosWorkerStore.java
---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.mesos.runtime.clusterframework.store;
    +
    +import com.google.common.collect.ImmutableList;
    +import org.apache.mesos.Protos;
    +import scala.Option;
    +
    +import java.util.LinkedHashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * A standalone Mesos worker store.
    + */
    +public class StandaloneMesosWorkerStore implements MesosWorkerStore {
    +
    +	private Option<Protos.FrameworkID> frameworkID = Option.empty();
    +
    +	private int taskCount = 0;
    +
    +	private Map<Protos.TaskID, Worker> storedWorkers = new LinkedHashMap<>();
    +
    +	public StandaloneMesosWorkerStore() {
    +	}
    +
    +	@Override
    +	public void start() throws Exception {
    +
    +	}
    +
    +	@Override
    +	public void stop() throws Exception {
    +
    +	}
    +
    +	@Override
    +	public Option<Protos.FrameworkID> getFrameworkID() throws Exception {
    +		return frameworkID;
    +	}
    +
    +	@Override
    +	public void setFrameworkID(Option<Protos.FrameworkID> frameworkID) throws Exception
{
    +		this.frameworkID = frameworkID;
    +	}
    +
    +	@Override
    +	public List<Worker> recoverWorkers() throws Exception {
    +		return ImmutableList.copyOf(storedWorkers.values());
    +	}
    +
    +	@Override
    +	public Protos.TaskID newTaskID() throws Exception {
    +		Protos.TaskID taskID = Protos.TaskID.newBuilder().setValue(TASKID_FORMAT.format(++taskCount)).build();
    +		return taskID;
    --- End diff --
    
    Could be simplified: `return Protos.TaskID.newBuilder().setValue(TASKID_FORMAT.format(++taskCount)).build();`.


> Integrate Flink with Apache Mesos
> ---------------------------------
>
>                 Key: FLINK-1984
>                 URL: https://issues.apache.org/jira/browse/FLINK-1984
>             Project: Flink
>          Issue Type: New Feature
>          Components: Cluster Management
>            Reporter: Robert Metzger
>            Assignee: Eron Wright 
>            Priority: Minor
>         Attachments: 251.patch
>
>
> There are some users asking for an integration of Flink into Mesos.
> -There also is a pending pull request for adding Mesos support for Flink-: https://github.com/apache/flink/pull/251
> Update (May '16):  a new effort is now underway, building on the recent ResourceManager
work.
> Design document:  ([google doc|https://docs.google.com/document/d/1WItafBmGbjlaBbP8Of5PAFOH9GUJQxf5S4hjEuPchuU/edit?usp=sharing])



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message