flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns
Date Tue, 02 Aug 2016 14:13:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404049#comment-15404049
] 

ASF GitHub Bot commented on FLINK-3677:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2109#discussion_r73162125
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
    @@ -274,7 +272,7 @@ public int compare(Tuple2<Long, List<FileInputSplit>>
o1, Tuple2<Long, List<File
     	 */
     	private boolean shouldIgnore(Path filePath, long modificationTime) {
     		assert (Thread.holdsLock(checkpointLock));
    -		boolean shouldIgnore = ((pathFilter != null && pathFilter.filterPath(filePath))
|| modificationTime <= globalModificationTime);
    +		boolean shouldIgnore = modificationTime <= globalModificationTime;
    --- End diff --
    
    Ah, you set a filter on the inputformat?


> FileInputFormat: Allow to specify include/exclude file name patterns
> --------------------------------------------------------------------
>
>                 Key: FLINK-3677
>                 URL: https://issues.apache.org/jira/browse/FLINK-3677
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Maximilian Michels
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>              Labels: starter
>
> It would be nice to be able to specify a regular expression to filter files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message