flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns
Date Tue, 02 Aug 2016 14:37:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404097#comment-15404097
] 

ASF GitHub Bot commented on FLINK-3677:
---------------------------------------

Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2109
  
    Just had a brief look. Looks nice. Actually, I like how you moved the file filter to the
`FileInputFormat` instead of having it as a special case of the file monitoring source. 
    
    I think you made at least one API breaking change which we will have to revert on `StreamExecutionEnvironment`
after the next release (1.1.0). I think nobody will use `GlobFilePathFilter` unless it is
documented. Could you revert the method changes on the environment and add some documentation?
    
    I would keep the default filter as it is. A lot of users wouldn't expect the default filter
to evaluate regular expressions.


> FileInputFormat: Allow to specify include/exclude file name patterns
> --------------------------------------------------------------------
>
>                 Key: FLINK-3677
>                 URL: https://issues.apache.org/jira/browse/FLINK-3677
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Maximilian Michels
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>              Labels: starter
>
> It would be nice to be able to specify a regular expression to filter files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message