flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns
Date Wed, 24 Aug 2016 13:25:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434927#comment-15434927
] 

ASF GitHub Bot commented on FLINK-3677:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2109#discussion_r76055091
  
    --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/DefaultFilterTest.java
---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.common.io;
    +
    +import java.util.Arrays;
    +import java.util.Collection;
    +
    +import org.apache.flink.core.fs.Path;
    +import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +import org.junit.runners.Parameterized.Parameters;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +@RunWith(Parameterized.class)
    +public class DefaultFilterTest {
    +	@Parameters
    +	public static Collection<Object[]> data() {
    +		return Arrays.asList(new Object[][] {
    +			{"file.txt",			false},
    +			{".file.txt",			true},
    +			{"_file.txt",			true},
    +			{"_COPYING_",			true},
    +			{"dir/.file.txt",		true},
    +			{"dir/_file.txt",		true},
    +			{"dir/_COPYING_",		true},
    --- End diff --
    
    It seems quite arbitrary that we exclude this file. I know that you didn't introduce that.
Still, could we move it to a constant and document it? This seems to be Hadoop's hack to indicate
an unfinished file.


> FileInputFormat: Allow to specify include/exclude file name patterns
> --------------------------------------------------------------------
>
>                 Key: FLINK-3677
>                 URL: https://issues.apache.org/jira/browse/FLINK-3677
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Maximilian Michels
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>              Labels: starter
>
> It would be nice to be able to specify a regular expression to filter files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message