flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3702) DataStream API PojoFieldAccessor doesn't support nested POJOs
Date Tue, 23 Aug 2016 09:46:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432513#comment-15432513
] 

ASF GitHub Bot commented on FLINK-3702:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2094#discussion_r75833200
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
    @@ -203,7 +205,26 @@ public void getFlatFields(String fieldExpression, int offset, List<FlatFieldDesc
     		TypeInformation<X> typed = (TypeInformation<X>) this.types[pos];
     		return typed;
     	}
    -	
    +
    +	@Override
    +	@PublicEvolving
    +	public <F> FieldAccessor<T, F> getFieldAccessor(int pos, ExecutionConfig
config) {
    +		return new FieldAccessor.SimpleTupleFieldAccessor<T, F>(pos, this);
    +	}
    +
    +	@Override
    +	@PublicEvolving
    +	public <F> FieldAccessor<T, F> getFieldAccessor(String fieldExpression,
ExecutionConfig config) {
    +		FieldAccessor.FieldExpressionDecomposition decomp = FieldAccessor.decomposeFieldExpression(fieldExpression);
    +		int FieldPos = this.getFieldIndex(decomp.head);
    --- End diff --
    
    `getFieldIndex()` can return -1. This should be handled somewhere. I think the constructors
of all accessors should check their input parameters (also for null etc.).


> DataStream API PojoFieldAccessor doesn't support nested POJOs
> -------------------------------------------------------------
>
>                 Key: FLINK-3702
>                 URL: https://issues.apache.org/jira/browse/FLINK-3702
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.0.0
>            Reporter: Robert Metzger
>            Assignee: Gabor Gevay
>
> The {{PojoFieldAccessor}} (which is used by {{.sum(String)}} and similar methods) doesn't
support nested POJOs right now.
> As part of FLINK-3697 I'll add a check for a nested POJO and fail with an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message