flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential
Date Mon, 01 Aug 2016 18:24:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402570#comment-15402570

ASF GitHub Bot commented on FLINK-3929:

Github user vijikarthi commented on a diff in the pull request:

    --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/RunTypeSelectionRunner.java
    @@ -0,0 +1,54 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.test.util;
    +import org.junit.runners.BlockJUnit4ClassRunner;
    +import org.junit.runners.model.FrameworkMethod;
    +import org.junit.runners.model.InitializationError;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    + * Custom JRunner used to run integration tests for Kafka in secure mode. Since the test
code implementation uses
    + * abstract base code to run the MiniFlinkCluster and also start/stop Kafka brokers depending
on the version (0.8/0.9)
    + * we need to know the run mode (CLEAR/SECURE) ahead of time (before the beforeClass).
This Runner instance
    + * take care of setting SECURE flag on the holder class for secure testing to work seamless
    + *
    + */
    +public class RunTypeSelectionRunner extends BlockJUnit4ClassRunner {
    --- End diff --
    I agree with you that it will be nice to control this behavior in @BeforeClass but the
challenge is controlling test run (secure vs insecure mode). The base class should be aware
of the run mode (secure/insecure) ahead of time and I found it very challenging especially
when the lifecycle of the services (MiniFlink, Kafka/ZK etc.,) are handled at different levels.
I ended up in using custom JRunner which gives the flexibility in handling the run level from
the top most layer (@Test class) without having to readjust the codebase much.

> Support for Kerberos Authentication with Keytab Credential
> ----------------------------------------------------------
>                 Key: FLINK-3929
>                 URL: https://issues.apache.org/jira/browse/FLINK-3929
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Eron Wright 
>            Assignee: Vijay Srinivasaraghavan
>              Labels: kerberos, security
>   Original Estimate: 672h
>  Remaining Estimate: 672h
> _This issue is part of a series of improvements detailed in the [Secure Data Access|https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs/edit?usp=sharing]
design doc._
> Add support for a keytab credential to be associated with the Flink cluster, to facilitate:
> - Kerberos-authenticated data access for connectors
> - Kerberos-authenticated ZooKeeper access
> Support both the standalone and YARN deployment modes.

This message was sent by Atlassian JIRA

View raw message