flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH
Date Tue, 02 Aug 2016 15:27:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404181#comment-15404181
] 

ASF GitHub Bot commented on FLINK-3940:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2282#discussion_r73177719
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
    @@ -71,11 +78,57 @@ class DataSetSort(
           partitionedDs = partitionedDs.sortPartition(fieldCollation._1, fieldCollation._2)
         }
     
    +    val offsetAndFetchDS = if (offset != null) {
    +      val offsetIndex = RexLiteral.intValue(offset)
    +      val fetchIndex = if (fetch != null) {
    +        RexLiteral.intValue(fetch) + offsetIndex
    --- End diff --
    
    Is it guaranteed that `fetch` can always be converted to an integer, esp. if it is coming
from SQL API?


> Add support for ORDER BY OFFSET FETCH
> -------------------------------------
>
>                 Key: FLINK-3940
>                 URL: https://issues.apache.org/jira/browse/FLINK-3940
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: GaoLun
>            Priority: Minor
>
> Currently only ORDER BY without OFFSET and FETCH are supported.
> This issue tracks the effort to add support for OFFSET and FETCH and involves:
> - Implementing the execution strategy in `DataSetSort`
> - adapting the `DataSetSortRule` to support OFFSET and FETCH
> - extending the Table API and validation to support OFFSET and FETCH and generate a corresponding
RelNode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message