flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment
Date Tue, 02 Aug 2016 14:40:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404102#comment-15404102
] 

ASF GitHub Bot commented on FLINK-4247:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2298
  
    Would be great to reflect the "do not use" with proper visibility. A JavaDoc comment is
usually not helping at all.
    
    Also, the dependency on the java API classes in the Scala classes does not seem right.
Usually the Scala classes hide the Java API streams and environments.
    
    Both of these things are usually strong indicators that there are some abstraction issues.
    Would be good to get that right, while the API is fresh and malleable.


> CsvTableSource.getDataSet() expects Java ExecutionEnvironment
> -------------------------------------------------------------
>
>                 Key: FLINK-4247
>                 URL: https://issues.apache.org/jira/browse/FLINK-4247
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>
> The Table API offers the {{CsvTableSource}} which can be used with the Java and Scala
API. However, if used with the Scala API where on has obtained a {{scala.api.ExecutionEnvironment}}
there is a problem with the {{CsvTableSource.getDataSet}} method. The method expects a {{java.api.ExecutionEnvironment}}
to extract the underlying {{DataSet}}. Additionally it returns a {{java.api.DataSet}} instead
of a {{scala.api.DataSet}}. I think we should also offer a Scala API specific CsvTableSource
which works with the respective Scala counterparts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message