flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment
Date Thu, 04 Aug 2016 21:31:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408524#comment-15408524
] 

ASF GitHub Bot commented on FLINK-4247:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2298
  
    +1 for sticking to Java DataSet / DataStream for the reasons @twalthr gave. The methods
should be tagged with the `@Internal` annotation when we add them to the Table API.
    
    I would not rename `TableSource` to `TableInputFormat` because 1) it has no relationship
to the `InputFormat` interface and 2) there is already a `TableInputFormat` for HBase tables
(name is not very fortunate though...).



> CsvTableSource.getDataSet() expects Java ExecutionEnvironment
> -------------------------------------------------------------
>
>                 Key: FLINK-4247
>                 URL: https://issues.apache.org/jira/browse/FLINK-4247
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>
> The Table API offers the {{CsvTableSource}} which can be used with the Java and Scala
API. However, if used with the Scala API where on has obtained a {{scala.api.ExecutionEnvironment}}
there is a problem with the {{CsvTableSource.getDataSet}} method. The method expects a {{java.api.ExecutionEnvironment}}
to extract the underlying {{DataSet}}. Additionally it returns a {{java.api.DataSet}} instead
of a {{scala.api.DataSet}}. I think we should also offer a Scala API specific CsvTableSource
which works with the respective Scala counterparts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message