flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4253) Rename "recovery.mode" config key to "high-availability"
Date Mon, 22 Aug 2016 15:53:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431055#comment-15431055

ASF GitHub Bot commented on FLINK-4253:

Github user uce commented on the issue:

    I had to address some things when reviewing this: https://github.com/uce/flink/tree/ram
    In general the changes were good, but overlooked many occurrences that are not possible
to catch with automatic refactoring tools. I went through those manually. I will merge this
after my local Travis build passes.

> Rename "recovery.mode" config key to "high-availability"
> --------------------------------------------------------
>                 Key: FLINK-4253
>                 URL: https://issues.apache.org/jira/browse/FLINK-4253
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: ramkrishna.s.vasudevan
> Currently, HA is configured via the following configuration keys:
> {code}
> recovery.mode: STANDALONE // No high availability (HA)
> recovery.mode: ZOOKEEPER // HA
> {code}
> This could be more straight forward by simply renaming the key to {{high-availability}}.
Furthermore, the term {{STANDALONE}} is overloaded. We already have standalone cluster mode.
> {code}
> high-availability: NONE // No HA
> high-availability: ZOOKEEPER // HA via ZooKeeper
> {code}
> The {{recovery.mode}} configuration keys would have to be deprecated before completely
removing them.

This message was sent by Atlassian JIRA

View raw message