flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4273) Refactor JobClientActor to watch already submitted jobs
Date Thu, 18 Aug 2016 13:29:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426463#comment-15426463
] 

ASF GitHub Bot commented on FLINK-4273:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2313#discussion_r75307091
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java
---
    @@ -100,13 +101,51 @@ public void testSubmissionTimeout() throws Exception {
     		Await.result(jobExecutionResult, timeout);
     	}
     
    +
    +	/** Tests that a {@link JobClientActorRegistrationTimeoutException} is thrown when the
registration
    +	 * cannot be performd at the JobManager by the JobClientActor. This is here the case,
because the
    +	 * started JobManager never replies to a {@link RegisterJobClient} message.
    +	 */
    +	@Test(expected=JobClientActorRegistrationTimeoutException.class)
    +	public void testRegistrationTimeout() throws Exception {
    +		FiniteDuration jobClientActorTimeout = new FiniteDuration(5, TimeUnit.SECONDS);
    +		FiniteDuration timeout = jobClientActorTimeout.$times(2);
    +
    +		UUID leaderSessionID = UUID.randomUUID();
    +
    +		ActorRef jobManager = system.actorOf(
    +			Props.create(
    +				PlainActor.class,
    +				leaderSessionID));
    +
    +		TestingLeaderRetrievalService testingLeaderRetrievalService = new TestingLeaderRetrievalService(
    +			jobManager.path().toString(),
    +			leaderSessionID
    +		);
    +
    +		Props jobClientActorProps = JobClientActor.createJobClientActorProps(
    +			testingLeaderRetrievalService,
    +			jobClientActorTimeout,
    +			false);
    +
    +		ActorRef jobClientActor = system.actorOf(jobClientActorProps);
    +
    +
    --- End diff --
    
    Two line breaks


> Refactor JobClientActor to watch already submitted jobs 
> --------------------------------------------------------
>
>                 Key: FLINK-4273
>                 URL: https://issues.apache.org/jira/browse/FLINK-4273
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The JobClientActor assumes that it receives a job, submits it, and waits for the result.
This process should be broken up into a submission process and a waiting process which can
both be entered independently. This leads to two different entry points:
> 1) submit(job) -> wait
> 2) retrieve(jobID) -> wait



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message