flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4282) Add Offset Parameter to WindowAssigners
Date Thu, 18 Aug 2016 13:23:22 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426452#comment-15426452
] 

ASF GitHub Bot commented on FLINK-4282:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2355#discussion_r75306168
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
    @@ -2550,4 +2550,36 @@ public String toString() {
     			return "EventTimeTrigger()";
     		}
     	}
    +
    +	@Test
    --- End diff --
    
    Very good that you added a test for this! 👍 
    
    I'd like to have these in a separate test for `TimeWindow`, however, since the `WindowOperatorTest`
file is already very big.


> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
>                 Key: FLINK-4282
>                 URL: https://issues.apache.org/jira/browse/FLINK-4282
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days are aligned
with GMT. This is somewhat problematic for people living in different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message