flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4310) Move BinaryCompatibility Check plugin to relevant projects
Date Thu, 04 Aug 2016 16:39:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408080#comment-15408080
] 

ASF GitHub Bot commented on FLINK-4310:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/2334

    [FLINK-4310] [build] Selectively run API compatibility checks in API projects.

    This moves the API compatibility checks into the API projects that use stability annotations.
    Previously, every project ran the tests, regardless of whether it contained public API
classes or not.
    
    API compatibility checks are done in
      - `flink-metrics-core`
      - `flink-core`
      - `flink-java`
      - `flink-scala`
      - `flink-streaming-scala`
      - `flink-streaming-java`
    
    Those were the projects where I found the `@Public` annotation being used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink selective_checks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2334
    
----
commit 5b77139c911cd50b5cce31fd2f9fe9ab9be520cf
Author: Stephan Ewen <sewen@apache.org>
Date:   2016-08-04T16:08:14Z

    [FLINK-4310] [build] Selectively run API compatibility checks in API projects.
    
    This moves the API compatibility checks into the API projects that use stability annotations.
    Previously, every project ran the tests, regardless of whether it contained public API
classes or not.

----


> Move BinaryCompatibility Check plugin to relevant projects
> ----------------------------------------------------------
>
>                 Key: FLINK-4310
>                 URL: https://issues.apache.org/jira/browse/FLINK-4310
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.1.0
>            Reporter: Stephan Ewen
>
> The Maven plugin that checks binary compatibility is currently run for every project,
rather than only the once where we have public API classes.
> Since the plugin contributes to build instability in some cases, we can improve stability
by running it only in the relevant projects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message