flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4414) Remove restriction on RpcService.getAddress
Date Thu, 18 Aug 2016 14:39:23 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426553#comment-15426553
] 

ASF GitHub Bot commented on FLINK-4414:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2381
  
    I'm actually not so sure whether it's such a big problem for the annotation check. You
simply don't consider the methods which have been declared by `RpcGateway` and you're done.
In this [commit](https://github.com/tillrohrmann/flink/commit/fc80d930dbf045592ca52b9e76fcafb260c13707)
you can see how I would do it. If this commit fulfils your requirements, then we can merge
it.
    
    This PR still contains unrelated changes such as the `RpcCompletenessTest` improvements.
This should be treated in a separate PR. The best thing is to either do a force push or to
close an re-open a PR in this case (then you get rid of the revert commit).


> Remove restriction on RpcService.getAddress
> -------------------------------------------
>
>                 Key: FLINK-4414
>                 URL: https://issues.apache.org/jira/browse/FLINK-4414
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
>
> currently {{RpcService}} provide only address of the endpoint, I think rpc service serve
both the endpoint create on it and the remote gateway create on it, so it is ok to offer the
getAddress to all {{RpcGateway}} created on the rpc service including the server and client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message