flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4414) Remove restriction on RpcService.getAddress
Date Thu, 18 Aug 2016 15:55:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426685#comment-15426685

ASF GitHub Bot commented on FLINK-4414:

Github user wenlong88 commented on the issue:

    Hi, @tillrohrmann 
     1. It looks good if you think it is not a bit deal that the interface RpcGateway contains
functions defined for specific business logic and functions defined for frameworks logic which
right now only contains `getAddress`. I treat it some kind of weird because I think the RpcGateway
interface is the business logic protocol of a RPC server, just like what we do in hadoop rpc
framework which also defines a interface to define what can do for a RPC server like the RPC
abstraction here.
    2. I find that in current AkkaRpcService has another problem that if we use a RpcService
to get a Endpoint's self address, but the endpoint is not created by the RpcService, we will
get a wrong too, just like the example you make. It need to do some check if we want to reserve
the function. and you commit solve the problem too.
    3. Sorry for the codes left behind in last revert. I have removed it.  But I think if
the concern in 1 is not a problem, your solution is better, and the PR can be discarded

> Remove restriction on RpcService.getAddress
> -------------------------------------------
>                 Key: FLINK-4414
>                 URL: https://issues.apache.org/jira/browse/FLINK-4414
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
> currently {{RpcService}} provide only address of the endpoint, I think rpc service serve
both the endpoint create on it and the remote gateway create on it, so it is ok to offer the
getAddress to all {{RpcGateway}} created on the rpc service including the server and client.

This message was sent by Atlassian JIRA

View raw message