flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4437) Lock evasion around lastTriggeredCheckpoint may lead to lost updates to related fields
Date Wed, 24 Aug 2016 10:05:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434634#comment-15434634
] 

ASF GitHub Bot commented on FLINK-4437:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2409
  
    Have to step back. This pull request is completely broken: It does not compile and after
fixing this the build fails with checkstyle errors.
    
    I would suggest to close it, I have actually reproduced this fix in the meantime.


> Lock evasion around lastTriggeredCheckpoint may lead to lost updates to related fields
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-4437
>                 URL: https://issues.apache.org/jira/browse/FLINK-4437
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> In CheckpointCoordinator#triggerCheckpoint():
> {code}
>         // make sure the minimum interval between checkpoints has passed
>         if (lastTriggeredCheckpoint + minPauseBetweenCheckpoints > timestamp) {
> {code}
> If two threads evaluate 'lastTriggeredCheckpoint + minPauseBetweenCheckpoints > timestamp'
in close proximity before lastTriggeredCheckpoint is updated, the two threads may have an
inconsistent view of "lastTriggeredCheckpoint" and updates to fields correlated with "lastTriggeredCheckpoint"
may be lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message