flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4451) Throw exception when remote connection cannot be resolved
Date Wed, 24 Aug 2016 11:21:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434728#comment-15434728
] 

ASF GitHub Bot commented on FLINK-4451:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2405#discussion_r76038499
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActorTest.java
---
    @@ -73,6 +75,22 @@ public void testAddressResolution() throws Exception {
     	}
     
     	/**
    +	 * Tests that a {@link RpcConnectionException} is thrown if the rpc endpoint cannot
be connected to.
    +	 */
    +	@Test
    +	public void testFailingAddressResolution() throws Exception {
    +		Future<DummyRpcGateway> futureRpcGateway = akkaRpcService.connect("foobar", DummyRpcGateway.class);
    +
    +		try {
    +			DummyRpcGateway gateway = Await.result(futureRpcGateway, timeout.duration());
    --- End diff --
    
    This should fail as soon as the future is completed (in this case failed with the exception).
The exception is thrown as soon as Akka returns an empty `ActorIdentity` message.


> Throw exception when remote connection cannot be resolved
> ---------------------------------------------------------
>
>                 Key: FLINK-4451
>                 URL: https://issues.apache.org/jira/browse/FLINK-4451
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{RpcService}} implementation should throw an exception (returned in the future)
if {{RpcService.connect(address, type)}} cannot connect to the remote {{RpcEndpoint}}.
> At the moment the {{AkkaRpcService}} does not check that the {{IdentifyActor}} message
contains a valid {{ActorRef}} and throws due to that a {{NullPointerException}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message