flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4451) Throw exception when remote connection cannot be resolved
Date Wed, 24 Aug 2016 11:25:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434731#comment-15434731
] 

ASF GitHub Bot commented on FLINK-4451:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2405#discussion_r76038921
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/registration/RetryingRegistration.java
---
    @@ -197,7 +197,7 @@ public void onSuccess(Gateway result) {
     				@Override
     				public void onFailure(Throwable failure) {
     					if (!isCanceled()) {
    -						log.warn("Could not resolve {} address {}, retrying...", targetName, targetAddress);
    +						log.warn("Could not resolve {} address {}, retrying...", targetName, targetAddress,
failure);
    --- End diff --
    
    I think you can according to http://stackoverflow.com/a/6374166/4815083 and I also just
tested it.


> Throw exception when remote connection cannot be resolved
> ---------------------------------------------------------
>
>                 Key: FLINK-4451
>                 URL: https://issues.apache.org/jira/browse/FLINK-4451
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{RpcService}} implementation should throw an exception (returned in the future)
if {{RpcService.connect(address, type)}} cannot connect to the remote {{RpcEndpoint}}.
> At the moment the {{AkkaRpcService}} does not check that the {{IdentifyActor}} message
contains a valid {{ActorRef}} and throws due to that a {{NullPointerException}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message