flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-4482) numUnsuccessfulCheckpointsTriggers is accessed without holding triggerLock
Date Wed, 24 Aug 2016 23:07:20 GMT
Ted Yu created FLINK-4482:
-----------------------------

             Summary: numUnsuccessfulCheckpointsTriggers is accessed without holding triggerLock
                 Key: FLINK-4482
                 URL: https://issues.apache.org/jira/browse/FLINK-4482
             Project: Flink
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


In CheckpointCoordinator#stopCheckpointScheduler() :
{code}
    synchronized (lock) {
...
      numUnsuccessfulCheckpointsTriggers = 0;
{code}
triggerLock is not held in the above operation.
See comment for triggerLock earlier in triggerCheckpoint():
{code}
    // we lock with a special lock to make sure that trigger requests do not overtake each
other.
    // this is not done with the coordinator-wide lock, because the 'checkpointIdCounter'
    // may issue blocking operations. Using a different lock than teh coordinator-wide lock,
    // we avoid blocking the processing of 'acknowledge/decline' messages during that time.
    synchronized (triggerLock) {
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message