flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2421: FLINK-4482 numUnsuccessfulCheckpointsTriggers is a...
Date Thu, 01 Sep 2016 12:05:55 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
    @@ -401,7 +402,7 @@ CheckpointTriggerResult triggerCheckpoint(long timestamp, CheckpointProperties
     				checkpointID = checkpointIdCounter.getAndIncrement();
     			catch (Throwable t) {
    -				int numUnsuccessful = ++numUnsuccessfulCheckpointsTriggers;
    +				int numUnsuccessful = numUnsuccessfulCheckpointsTriggers.addAndGet(1);
    --- End diff --
    Minor: `incrementAndGet()` reads nice here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message