flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Thu, 01 Sep 2016 13:54:26 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r77177744
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -2041,6 +2044,18 @@ object JobManager {
             null
         }
     
    +    val secureAuth = configuration.getBoolean(ConfigConstants.SECURITY_ENABLED,
    +                                              ConfigConstants.DEFAULT_SECURITY_ENABLED)
    +    if(secureAuth == true) {
    +      val secureCookie = configuration.getString(ConfigConstants.SECURITY_COOKIE, null)
    +      if(secureCookie == null) {
    +        val message = "Missing " + ConfigConstants.SECURITY_COOKIE +
    +                      " configuration in Flink configuration file"
    +        LOG.error(message)
    +        throw new RuntimeException(message)
    +      }
    +    }
    --- End diff --
    
    As I said before, this is duplicate code that can be encapsulated into a `SecurityUtils`
static method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message