flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Thu, 01 Sep 2016 14:14:44 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r77181460
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
    @@ -597,6 +610,11 @@ public static ContainerLaunchContext createTaskManagerContext(
     
     		containerEnv.put(YarnConfigKeys.ENV_CLIENT_USERNAME, yarnClientUsername);
     
    +		final String secureCookie = ENV.get(YarnConfigKeys.ENV_SECURE_AUTH_COOKIE);
    +		if(secureCookie != null) {
    +			containerEnv.put(YarnConfigKeys.ENV_SECURE_AUTH_COOKIE, secureCookie);
    --- End diff --
    
    The problem here is that the secure cookie will be put into the environment of the TaskManager
JVM, so it'll be quite easy to just read the environment variables (not sure if that is an
issue).
    Another issue is that YARN is by default launching processes by creating a temporary bash
file, with all the environment variables and the JVM invocation. So the secure cookie will
be written into some tmp directory on YARN.
    I wonder if there's some infrastructure in YARN to transfer the tokens in a secure way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message