flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...
Date Fri, 02 Sep 2016 08:28:35 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2447#discussion_r77310730
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java
---
    @@ -104,16 +107,17 @@ public String toString() {
     					(producerState == ExecutionState.RUNNING
     							|| producerState == ExecutionState.FINISHED)) {
     
    -				final Instance partitionInstance = producerSlot.getInstance();
    +				final TaskManagerLocation partitionTaskManagerLocation = producerSlot.getTaskManagerLocation();
    +				final ResourceID partitionTaskManager = partitionTaskManagerLocation.getResourceID();
    --- End diff --
    
    But in the future the partition might reside on a machine which was not the producer.
Thus, I guess that it's good then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message