flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...
Date Tue, 06 Sep 2016 13:06:50 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77629858
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotStatus.java
---
    @@ -46,13 +47,21 @@
     	/** if the slot is allocated, jobId identify which job this slot is allocated to; else,
jobId is null */
     	private final JobID jobID;
     
    -	public SlotStatus(SlotID slotID, ResourceProfile profiler) {
    -		this(slotID, profiler, null, null);
    +	/** Gateway to the TaskManager which reported the SlotStatus */
    +	private final TaskExecutorGateway taskExecutorGateway;
    --- End diff --
    
    It comes with the SlotReport from the TaskExecutor. Yes, it breaks Serializable. Will
change the code to contain the String address instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message