flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...
Date Wed, 07 Sep 2016 08:56:19 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77783497
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
    @@ -15,11 +15,27 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    +package org.apache.flink.runtime.highavailability;
     
    -package org.apache.flink.runtime.resourcemanager;
    +import java.util.UUID;
     
    -import java.io.Serializable;
    +/**
    + * Registry class to keep track of the current leader ID.
    + */
    +public class LeaderIdRegistry {
    --- End diff --
    
    What exactly do you mean? The class is thread-safe and documented (though documentation
can be improved). There is no need for locking. Do you mean marking the leaderSessionID `volatile`?
It should be fine if leader changes propagate lazily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message