flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...
Date Thu, 08 Sep 2016 11:08:59 GMT
Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2211#discussion_r77986502
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
    @@ -70,10 +77,41 @@
     	private static final Pattern PATTERN_NESTED_FIELDS = Pattern.compile(REGEX_NESTED_FIELDS);
     	private static final Pattern PATTERN_NESTED_FIELDS_WILDCARD = Pattern.compile(REGEX_NESTED_FIELDS_WILDCARD);
     
    +	private static final Map<Class<?>, Class<? extends TypeSerializer>>
customSerializers = new HashMap<>();
    +	private static final Map<Tuple2<ArrayList<Integer>, Class>, Class<?
extends TypeComparator>> customComparators =
    +		new HashMap<>();
    +
     	private final PojoField[] fields;
     	
     	private final int totalFields;
     
    +	/**
    +	 * Register a custom serializer for a type. The precedence of the serializers
    +	 * is the following (highest to lowest): Kryo, Avro, Custom, Generated, Flink.
    +	 * The chosen serializer will be the first one from the list that is turned on.
    --- End diff --
    
    I think the wording "turned on" is a bit confusing, because it means different things
for the different elements of this list.
    - I guess for Kryo, Avro, and Generater, you mean `enableForceKryo`, `enableForceAvro`,
`enableCodeGeneration` was called?
    - For "Custom", you mean that this method was called for the particular type.
    - For "Flink", you are talking about `PojoSerializer`? This is kind of always turned on.
However, it is not always applicable (if the type is not a POJO), in which case we fall back
to Kryo, even if it is not "turned on" in the above sense, which is also confusing.
    
    Another problem is that I'm not sure what happens with Tuples (and basic types and other
special types) if `enableForceKryo` was called. I guess they don't participate in this mess
and always get serialized by their special built-in serializers?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message