flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...
Date Fri, 09 Sep 2016 09:07:51 GMT
Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2211#discussion_r78149815
  
    --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerTest.java
---
    @@ -50,7 +50,6 @@
     	@Override
     	protected TypeSerializer<TestUserClass> createSerializer() {
     		TypeSerializer<TestUserClass> serializer = type.createSerializer(new ExecutionConfig());
    -		assert(serializer instanceof PojoSerializer);
    --- End diff --
    
    If I understand correctly, this test originally tested `PojoSerializer`, and now it is
testing the generated serializers only. I think it would be good to tweak it to also test
PojoSerializer. You could probably do this by creating a subclass of this class, where you
override `createSerializer`, and pass an `ExecutionConfig` with codegen disabled.
    
    Additionally, maybe you could also add a test that checks compatibility between `PojoSerializer`
and the generated serializers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message