flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...
Date Fri, 09 Sep 2016 09:34:26 GMT
Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2211#discussion_r78153259
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
    @@ -71,13 +139,18 @@ public ClassLoaderObjectInputStream(InputStream in, ClassLoader classLoader)
thr
     						// return primitive class
     						return cl;
     					} else {
    -						// throw ClassNotFoundException
    -						throw ex;
    +						// search among the compiled classes too
    +						return Class.forName(name, false, loaderForGeneratedClasses.get(name));
     					}
     				}
     			}
     
    -			return super.resolveClass(desc);
    +			try {
    +				return super.resolveClass(desc);
    +			} catch (ClassNotFoundException ex) {
    +				// It is possible the the passed class loader is null but we still want to load generated
classes.
    --- End diff --
    
    "the the"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message