flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request #2060: [FLINK-3921] StringParser encoding
Date Fri, 09 Sep 2016 15:25:35 GMT
Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2060#discussion_r78199216
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
    @@ -314,6 +320,25 @@ protected void setFieldsGeneric(boolean[] includedMask, Class<?>[]
fieldTypes) {
     		this.fieldIncluded = includedMask;
     	}
     
    +	/**
    +	 * Gets the Charset for the parser.Default is set to UTF-8
    --- End diff --
    
    Should we spell out `charset` as "character set" in the documentation? Also, space after
period and missing period at end.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message