flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...
Date Sat, 10 Sep 2016 20:48:44 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java
    @@ -133,10 +133,6 @@ public DefaultCross(DataSet<I1> input1, DataSet<I2> input2,
CrossHint hint, Stri
     					new TupleTypeInfo<Tuple2<I1, I2>>(input1.getType(), input2.getType()),
     					hint, defaultName);
    -			if (input1 == null || input2 == null) {
    -				throw new NullPointerException();
    -			}
    --- End diff --
    yes, but if you used the preconditions check you could supply a useful error message,
for example stating which input was actually null.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message