flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...
Date Thu, 15 Sep 2016 16:49:21 GMT
Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2496#discussion_r79010283
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
    @@ -87,4 +87,6 @@
     	 * @throws Exception Exceptions may be forwarded.
     	 */
     	void cancel() throws Exception;
    +
    +	void resetForIterativeTasks() throws Exception;
    --- End diff --
    
    > You mean all drivers will now become a type of ResettableDriver?
    
    Yes, this was the idea in my comment [1] on the Jira. I'm sorry if I wasn't clear enough
there.
    The advantage of this is that you wouldn't need to add more logic in `BatchTask`, `AbstractIterativeTask`
and its descendants, because these already handle the situation when the driver is an instance
of `ResettableDriver`. (See e.g. the beginning of `reinstantiateDriver`.)
    
    [1] https://issues.apache.org/jira/browse/FLINK-3322?focusedCommentId=15474531&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15474531


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message