flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...
Date Thu, 15 Sep 2016 19:05:22 GMT
Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2496#discussion_r79038567
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
    @@ -87,4 +87,6 @@
     	 * @throws Exception Exceptions may be forwarded.
     	 */
     	void cancel() throws Exception;
    +
    +	void resetForIterativeTasks() throws Exception;
    --- End diff --
    
    Currently, the `ResettableDriver` interface extends the `Driver` interface. I would say
that for the moment, let's just start by making some of the drivers resettable in this PR,
and keep both interfaces around. And then when this PR is merged, a second PR could make all
the remaing drivers resettable as well. And then a third one could merge the functionality
of `ResettableDriver` into `Driver`, and thus get rid of `ResettableDriver`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message