flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2275: FLINK-3929 Support for Kerberos Authentication wit...
Date Fri, 16 Sep 2016 12:11:39 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2275#discussion_r79152436
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
    @@ -79,9 +82,8 @@ public static void install(SecurityConfiguration config) throws Exception
{
     		JaasConfiguration jaasConfig = new JaasConfiguration(config.keytab, config.principal);
     		javax.security.auth.login.Configuration.setConfiguration(jaasConfig);
     
    -		//hack since Kafka Login Handler explicitly looks for the property or else it throws
an exception
    -		//https://github.com/apache/kafka/blob/0.9.0/clients/src/main/java/org/apache/kafka/common/security/kerberos/Login.java#L289
    -		System.setProperty("java.security.auth.login.config", "");
    +		//temporary fix
    +		populateJaasConfigSystemProperty(config.flinkConf);
    --- End diff --
    
    From my experience comments like "temporary fix" tend to stay forever. I would replace
it with something that explains the reasoning. That helps to fix the code when it is reviewed
later on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message