flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...
Date Mon, 19 Sep 2016 11:21:40 GMT
Github user ggevay commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/JoinTaskIterator.java
    @@ -68,4 +72,9 @@
     	 * method signals an interrupt to that procedure.
     	void abort();
    +	/**
    +	 * Allows to reset the iterator
    +	 */
    +	void reset(MutableObjectIterator<V1> in1, MutableObjectIterator<V2> in2,
TypeSerializer<V1> serializer1, TypeSerializer<V2> serializer2, TypeComparator<V1>
comp1, TypeComparator<V2> comp2, TypePairComparatorFactory<V1, V2> pairComparatorFactory);
    --- End diff --
    Could you pass in only those objects here, which might change during a reset? I think
these should only be the two inputs.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message