flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...
Date Wed, 21 Sep 2016 15:19:14 GMT
Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
    @@ -326,6 +322,9 @@ public Long getValue() {
     			// stop all timers and threads
     			if (timerService != null) {
     				try {
    +					if (!timerService.isTerminated()) {
    --- End diff --
    Should the actual call to `shutdownService()` also be inside the if block?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message